[WebServerBundle] Prevent console.terminate from being fired when server:start finishes #24908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Nov 10, 2017
Member
|
Thank you @kbond. |
fabpot
added a commit
that referenced
this pull request
Nov 10, 2017
…ed when server:start finishes (kbond) This PR was merged into the 3.4 branch. Discussion ---------- [WebServerBundle] Prevent console.terminate from being fired when server:start finishes | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24885 | License | MIT | Doc PR | n/a When the cache is cleared between `server:start` and `server:stop` the container used in `server:start` is no longer valid. Firing the `console.terminate` event throws an exception. This PR clears the event dispatcher so `console.terminate` is not fired. Commits ------- 699339e [WebServerBundle] prevent console.terminate from being fired after stopping server
This was referenced Nov 12, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the cache is cleared between
server:startandserver:stopthe container used inserver:startis no longer valid. Firing theconsole.terminateevent throws an exception. This PR clears the event dispatcher soconsole.terminateis not fired.