[WebserverBundle] fixed the bug that caused that the webserver would … #24881
Conversation
…start anyway even you said N.
carsonbot
added
Status: Needs Review
Bug
Status: Needs Work
and removed
Status: Needs Review
labels
| )); | ||
|
|
||
| if ($io->ask('Do you want to execute <info>server:run</info> immediately? [yN] ', false)) { | ||
| if ($io->confirm('Do you want to execute <info>server:run</info> immediately? [yN] ', false)) { |
There was a problem hiding this comment.
[yN] should be removed (it's automatically added when using confirm())
There was a problem hiding this comment.
Removed the yN and committed. Thanks.
|
FYI it seems like your git user is not recognized by github, you probably need to register a new email address on github from the output of |
ro0NL
left a comment
ro0NL
left a comment
There was a problem hiding this comment.
Hm i recognize this change :) see https://github.com/symfony/symfony/pull/22317/files#diff-15a026db1c07d66e0572d8302ad7d717
to mergers: already in 3.4
|
True. It is already fixed in 3.4 :) |
|
Thank you @SerkanYildiz. |
…rver would … (Serkan Yildiz) This PR was squashed before being merged into the 3.3 branch (closes #24881). Discussion ---------- [WebserverBundle] fixed the bug that caused that the webserver would … Fixed the bug that caused that the webserver would start anyway even you said N. | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24879 | License | MIT | Doc PR | / Commits ------- c256782 [WebserverBundle] fixed the bug that caused that the webserver would …
|
Congrats for your first Symfony PR @SerkanYildiz! |
|
Thank you guys! |
6 participants
Fixed the bug that caused that the webserver would start anyway even you said N.