-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[DI] Register default env var provided types #24635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
That's a BC break. |
|
Against a BETA release? Affected code is a new 3.4 feat 🤔 |
|
I would consider it as a bug fix also. |
|
Right, the bugfix in disguise is calling setProvidedTypes(). Following gettype() names is just something i think we need to choose now and be future proof (or at least is the desired behavior we want). |
|
I think we should keep the current types, The problem is |
|
Hm good point. We dont respect gettype() returning "double" either. 👍 for shortnames from me. |
|
Status: needs work |
|
Status: needs review cc @jvasseur |
|
Thank you @ro0NL. |
This PR was merged into the 3.4 branch. Discussion ---------- [DI] Register default env var provided types | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23888 (comment) | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> cc @nicolas-grekas Commits ------- 3cee7a6 [DI] Register default env var provided types
cc @nicolas-grekas