[WebServerBundle] Prevent commands from being registered by convention #24630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chalasr
commented
Oct 19, 2017
chalasr
commented
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #24629 |
| License | MIT |
| Doc PR | n/a |
chalasr
force-pushed
the
web-server-register-commands
branch
7 times, most recently
from
2a02280 to
3a374e4
Compare
fabpot
approved these changes
Oct 19, 2017
| { | ||
| public function registerCommands(Application $application) | ||
| { | ||
| // noop |
Member
There was a problem hiding this comment.
This may be technically correct, but it looks super strange, mostly because Symfony is always so explicit.
Member
Author
There was a problem hiding this comment.
should be more explicit now
chalasr
force-pushed
the
web-server-register-commands
branch
from
3a374e4 to
4cdbff5
Compare
stof
reviewed
Oct 19, 2017
| { | ||
| public function registerCommands(Application $application) | ||
| { | ||
| // prevents convention based registration of console commands as they are registered as services |
Member
There was a problem hiding this comment.
well, the existing logic already prevents it if they are defined as services
Member
Author
There was a problem hiding this comment.
indeed, useless. reverted
chalasr
force-pushed
the
web-server-register-commands
branch
from
4cdbff5 to
57b7d83
Compare
javiereguiluz
approved these changes
Oct 19, 2017
ogizanagi
approved these changes
Oct 19, 2017
Member
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Oct 19, 2017
…y convention (chalasr) This PR was merged into the 3.4 branch. Discussion ---------- [WebServerBundle] Prevent commands from being registered by convention | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24629 | License | MIT | Doc PR | n/a Commits ------- 57b7d83 [WebServerBundle] Prevent commands from being registered by convention
This was referenced Oct 30, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.