Catching deprecations in isolated tests always adds to the Legacy group #24568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexpott
commented
Oct 15, 2017
alexpott
commented
| Q | A |
|---|---|
| Branch? | 3.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #24567 |
| License | MIT |
| Doc PR | symfony/symfony-docs#... |
Contributor
Author
|
I've been trying to work out how to test this. Looking at the existing tests, I'm not sure \Symfony\Bridge\PhpUnit\Tests\ProcessIsolationTest tests what it thinks it does. Because if you change the expected deprecation message then it does not fail. I think this is because we're not actually adding the deprecation listener. |
Contributor
Author
|
Here's a related PR that might make this easier to test. #24575 |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 24, 2017
…(xabbuh) This PR was merged into the 3.3 branch. Discussion ---------- [PhpUnitBridge] fix deprecation triggering test detection | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24548 (comment), #24568 | License | MIT | Doc PR | Commits ------- da617e8 fix deprecation triggering test detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.