[DI] Throw accurate failures when accessing removed services #24484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Shouldn't we keep these synthetic and removed IDs in the container only for debug environments? Because here the value is only DX and the container is in theory taking more memory than before. |
Member
Author
|
Introducing a different behavior between debug and non-debug is something that could led to subtle bugs, so should be prevented as much as possible. |
fabpot
approved these changes
Oct 9, 2017
Member
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 10, 2017
…rvices (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Throw accurate failures when accessing removed services | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24444 | License | MIT | Doc PR | - See linked issue. This will throw a useful message when accessing a removed service. When setting a removed service, a deprecation notice will be thrown also so that in master we can throw an exception then. Commits ------- fe7f26d [DI] Throw accurate failures when accessing removed services
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See linked issue.
This will throw a useful message when accessing a removed service.
When setting a removed service, a deprecation notice will be thrown also so that in master we can throw an exception then.