[Cache] Fix lazy Memcached connections #23971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Aug 24, 2017
Member
chalasr
left a comment
chalasr
left a comment
There was a problem hiding this comment.
👍 with minor comment (needs rebase also)
| $opt = $client->getOption(\Memcached::OPT_SERIALIZER); | ||
| if (\Memcached::SERIALIZER_PHP !== $opt && \Memcached::SERIALIZER_IGBINARY !== $opt) { | ||
| throw new CacheException('MemcachedAdapter: "serializer" option must be "php" or "igbinary".'); | ||
| if (get_class($client) === 'Memcached') { |
Member
Author
There was a problem hiding this comment.
what is yoda here? :)
nicolas-grekas
force-pushed
the
memcache-lazy
branch
from
8641889 to
d8c400b
Compare
Member
Author
|
rebase done |
ogizanagi
approved these changes
Aug 26, 2017
fabpot
approved these changes
Aug 26, 2017
Member
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Aug 26, 2017
This PR was merged into the 3.3 branch. Discussion ---------- [Cache] Fix lazy Memcached connections | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - By calling methods on the Memcached instance on cache pool initialization, we defeat the purpose of lazy proxies, if anyone wanted to use one. Commits ------- d8c400b [Cache] Fix lazy Memcached connections
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By calling methods on the Memcached instance on cache pool initialization, we defeat the purpose of lazy proxies, if anyone wanted to use one.