Skip to content

Conversation

@Seb33300
Copy link
Contributor

@Seb33300 Seb33300 commented Jul 27, 2017

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #10271
License MIT
Doc PR

Repeat preferred choices in the main list so we can easily find them in large lists.

@HeahDude
Copy link
Contributor

This should be a new feature.

@nicolas-grekas
Copy link
Member

This breaks tests, which means the previous behavior was the expected one.
If this is a new feature, it should be opt-in to not break existing apps, isn't it?

@xabbuh xabbuh added this to the 2.7 milestone Aug 1, 2017
@jakzal
Copy link
Contributor

jakzal commented Oct 25, 2017

@Seb33300 indeed, being a new feature this should be sent to master. Are you still interested in implementing it?

@Seb33300
Copy link
Contributor Author

Unfortunately, I don't have the time to work on this at this time.
So if someone want to work on it, feel free to do it.

@jakzal
Copy link
Contributor

jakzal commented Oct 25, 2017

That's fine. Let's close for now.

@jakzal jakzal closed this Oct 25, 2017
@Seb33300 Seb33300 changed the base branch from 2.7 to master September 18, 2018 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants