Skip to content

[Component][Serializer][Normalizer] : Deal it with Has Method for the Normalizer/Denormalizer #23337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabpot merged 1 commit into from
Jul 6, 2017
Merged

[Component][Serializer][Normalizer] : Deal it with Has Method for the Normalizer/Denormalizer #23337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Symfony/Component/Serializer/Normalizer/GetSetMethodNormalizer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ private function isGetMethod(\ReflectionMethod $method)
!$method->isStatic() &&
(
((0 === strpos($method->name, 'get') && 3 < $methodLength) ||
(0 === strpos($method->name, 'is') && 2 < $methodLength)) &&
(0 === strpos($method->name, 'is') && 2 < $methodLength) ||
(0 === strpos($method->name, 'has') && 3 < $methodLength)) &&
0 === $method->getNumberOfRequiredParameters()
)
;
Expand Down Expand Up @@ -133,6 +134,11 @@ protected function getAttributeValue($object, $attribute, $format = null, array
if (is_callable(array($object, $isser))) {
return $object->$isser();
}

$haser = 'has'.$ucfirsted;
if (is_callable(array($object, $haser))) {
return $object->$haser();
}
}

/**
Expand Down
32 changes: 32 additions & 0 deletions src/Symfony/Component/Serializer/Tests/Normalizer/GetSetMethodNormalizerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,23 @@ public function testPrivateSetter()
$this->assertEquals('bar', $obj->getFoo());
}

public function testHasGetterDenormalize()
{
$obj = $this->normalizer->denormalize(array('foo' => true), ObjectWithHasGetterDummy::class);
$this->assertTrue($obj->hasFoo());
}

public function testHasGetterNormalize()
{
$obj = new ObjectWithHasGetterDummy();
$obj->setFoo(true);

$this->assertEquals(
array('foo' => true),
$this->normalizer->normalize($obj, 'any')
);
}

public function testMaxDepth()
{
$classMetadataFactory = new ClassMetadataFactory(new AnnotationLoader(new AnnotationReader()));
Expand Down Expand Up @@ -807,3 +824,18 @@ public static function setFoo($foo)
self::$foo = $foo;
}
}

class ObjectWithHasGetterDummy
{
private $foo;

public function setFoo($foo)
{
$this->foo = $foo;
}

public function hasFoo()
{
return $this->foo;
}
}