[Cache] Fallback to positional when keyed results are broken #23065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
memcached
branch
5 times, most recently
from
3627e34 to
d209bd8
Compare
Member
Author
|
Ready, now with a notice about MemcachedAdapter + TagAwareAdapter. |
fabpot
requested changes
Jun 5, 2017
| * - tags eviction by Memcached's LRU algorithm will break by-tags invalidation; | ||
| * your Memcached memory should be large enough to never trigger LRU. | ||
| * | ||
| * Using a MemcachedAdapter as a pure items store is fine of course. |
fabpot
approved these changes
Jun 5, 2017
Member
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jun 5, 2017
…en (nicolas-grekas) This PR was merged into the 3.3 branch. Discussion ---------- [Cache] Fallback to positional when keyed results are broken | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Works around krakjoe/apcu#247 ~~and facebook/hhvm#7867 Commits ------- 28aaa8e [Cache] Fallback to positional when keyed results are broken
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around krakjoe/apcu#247
and facebook/hhvm#7867