[Security] remove deprecated features #22821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
May 21, 2017
xabbuh
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
xabbuh
force-pushed
the
security-remove-deprecated-features
branch
from
5498aa8 to
eaecadd
Compare
chalasr
reviewed
May 21, 2017
| * @param string|null $context The listener context | ||
| */ | ||
| public function registerListener($key, $logoutPath, $csrfTokenId, $csrfParameter, CsrfTokenManagerInterface $csrfTokenManager = null/*, string $context = null*/) | ||
| public function registerListener($key, $logoutPath, $csrfTokenId, $csrfParameter, CsrfTokenManagerInterface $csrfTokenManager = null, $context = null) |
xabbuh
force-pushed
the
security-remove-deprecated-features
branch
2 times, most recently
from
1f6e794 to
be387ed
Compare
ogizanagi
reviewed
May 21, 2017
| You should implement this method yourself in your concrete authenticator. | ||
| * removed the `AccessDecisionManager::setVoters()` method | ||
| * removed the `RoleInterface` | ||
| * added a sixth `$context` argument to the `LogoutUrlGenerator::registerListener()` |
Contributor
There was a problem hiding this comment.
This one is already done in #22740 (sorry, hard to track)
xabbuh
force-pushed
the
security-remove-deprecated-features
branch
from
be387ed to
6a11506
Compare
Member
|
FC layer missing in fact |
Member
Author
|
see #22830 |
xabbuh
force-pushed
the
security-remove-deprecated-features
branch
from
6a11506 to
97bbf7c
Compare
nicolas-grekas
added a commit
that referenced
this pull request
May 21, 2017
…buh) This PR was merged into the 3.4 branch. Discussion ---------- [SecurityBundle] forward compatibility with Symfony 4 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | #22821 (comment) Commits ------- c783e1e forward compatibility with Symfony 4
symfony-splitter
pushed a commit
to symfony/security-bundle
that referenced
this pull request
May 21, 2017
…buh) This PR was merged into the 3.4 branch. Discussion ---------- [SecurityBundle] forward compatibility with Symfony 4 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony#22821 (comment) Commits ------- c783e1e forward compatibility with Symfony 4
Member
|
rebase needed |
xabbuh
force-pushed
the
security-remove-deprecated-features
branch
from
97bbf7c to
236379a
Compare
xabbuh
force-pushed
the
security-remove-deprecated-features
branch
from
236379a to
2397504
Compare
Member
Author
|
rebased, tests pass |
Member
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
May 21, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [Security] remove deprecated features | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 2397504 [Security] remove deprecated features
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.