[Security] Remove polyfill-util dependancy from security-core #22709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security-core no longer directly depends upon polyfill-util since #16382. This does not change the existing dependancy tree as polyfill-util is transitivly depended on via polyfill-php56.
BPScott
changed the title
Member
|
Good catch, thanks @BPScott. |
fabpot
added a commit
that referenced
this pull request
May 13, 2017
…-core (BPScott) This PR was merged into the 3.3-dev branch. Discussion ---------- [Security] Remove polyfill-util dependancy from security-core | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Security-core no longer directly depends upon polyfill-util since #16382. This does not change the existing dependancy tree as polyfill-util is transitivly depended on via polyfill-php56. Commits ------- fb140aa Remove polyfill-util dependancy from security-core
Contributor
Author
|
Whoops, the change it was removed in was #16392, yay fat fingers |
Tobion
added a commit
that referenced
this pull request
Jan 15, 2018
…ity (thewilkybarkid) This PR was merged into the 3.3 branch. Discussion ---------- Remove polyfill-util dependency from fullstack and security | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | kinda | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Applies #22709 to the two higher-level packages. I've applied it to 3.3 as that's where that change was merged (though it was `master` as the time); these may actually apply earlier though? (#16382 was mentioned and applied to 2.8, though is for the serializer which is unrelated? Should have been 3.0 when `StringUtils` was removed?) Commits ------- 939efd5 Remove polyfill-util dependency from fullstack and security
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Security-core no longer directly depends upon polyfill-util since #16382.
This does not change the existing dependancy tree as polyfill-util is
transitivly depended on via polyfill-php56.