[FrameworkBundle] AbstractConfigCommand: do not try registering bundles twice #22669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
May 10, 2017
javiereguiluz
approved these changes
May 11, 2017
Member
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
May 11, 2017
…ering bundles twice (ogizanagi) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] AbstractConfigCommand: do not try registering bundles twice | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/recipes#46 | License | MIT | Doc PR | N/A As spotted in symfony/recipes#46, there is no reason to call `registerBundles` on the kernel instance, as it's already booted. So we just have to use `getBundles` instead and `registerBundles` can be implemented in a non-rewindable way, as done with flex. Commits ------- 040edfe [FrameworkBundle] AbstractConfigCommand: do not try registering bundles twice
Merged
This was referenced May 29, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As spotted in symfony/recipes#46, there is no reason to call
registerBundleson the kernel instance, as it's already booted. So we just have to usegetBundlesinstead andregisterBundlescan be implemented in a non-rewindable way, as done with flex.