Skip to content

[Form] Improve the exceptions when trying to get the data in a PRE_SET_DATA listener and the data has not already been set #22140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabpot merged 1 commit into from
Mar 31, 2017
Merged

[Form] Improve the exceptions when trying to get the data in a PRE_SET_DATA listener and the data has not already been set #22140

fabpot merged 1 commit into from
Mar 31, 2017

Conversation

@fancyweb
Copy link
Contributor

@fancyweb fancyweb commented Mar 24, 2017 •
edited
Loading

Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #22103
License MIT
Doc PR -

@fancyweb
[Form] Improve the exceptions when trying to get the data in a PRE_SE…
ef39b70 
…T_DATA listener and the data has not already been set
@javiereguiluz javiereguiluz added the DX DX = Developer eXperience (anything that improves the experience of using Symfony) label Mar 24, 2017
@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Mar 24, 2017
stof
stof approved these changes Mar 30, 2017
View reviewed changes
Copy link
Member

@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stof
Copy link
Member

stof commented Mar 30, 2017

Status: reviewed

@fabpot
Copy link
Member

fabpot commented Mar 31, 2017

Thank you @fancyweb.

@fabpot fabpot merged commit ef39b70 into symfony:2.7 Mar 31, 2017
fabpot added a commit that referenced this pull request Mar 31, 2017
@fabpot
bug #22140 [Form] Improve the exceptions when trying to get the data …
6008489 
…in a PRE_SET_DATA listener and the data has not already been set (fancyweb)

This PR was merged into the 2.7 branch.

Discussion
----------

[Form] Improve the exceptions when trying to get the data in a PRE_SET_DATA listener and the data has not already been set

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22103
| License       | MIT
| Doc PR        | -

Commits
-------

ef39b70 [Form] Improve the exceptions when trying to get the data in a PRE_SET_DATA listener and the data has not already been set
@fancyweb fancyweb deleted the improve-some-form-exceptions-messages branch March 31, 2017 14:44
This was referenced Apr 4, 2017
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stof stof stof approved these changes

Assignees

No one assigned

Labels

DX DX = Developer eXperience (anything that improves the experience of using Symfony) Form Status: Reviewed

Projects

None yet

Milestone

2.7

Development

Successfully merging this pull request may close these issues.

6 participants

@fancyweb @stof @fabpot @javiereguiluz @nicolas-grekas @carsonbot