[DoctrineBridge] make sure that null can be the invalid value #21562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Feb 7, 2017
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #21554 |
| License | MIT |
| Doc PR |
HeahDude
reviewed
Feb 7, 2017
| protected $id; | ||
|
|
||
| /** @Column(type="string") */ | ||
| /** @Column(type="string", nullable=true) */ |
Contributor
There was a problem hiding this comment.
Maybe this deserves a DoubleNullableNameEntity to keep testing the old config and be sure to prevent any regressions for both cases. What do you think?
Member
Author
|
This needs more work (see #21554 (comment)). Status: Needs work |
Member
Author
|
#21554 (comment) addressed Status: Needs Review |
Member
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Feb 12, 2017
…lue (xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- [DoctrineBridge] make sure that null can be the invalid value | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21554 | License | MIT | Doc PR | Commits ------- c3702c2 make sure that null can be the invalid value
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.