[Cache] Fix class exists checks in PhpArrayAdapter #21528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
added a commit
that referenced
this pull request
Feb 5, 2017
…s-grekas) This PR was merged into the 3.2 branch. Discussion ---------- [Cache] Fix class exists checks in PhpArrayAdapter | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Fixes HHVM, as spotted in #21527 Commits ------- 44e5989 [Cache] Fix class exists checks in PhpArrayAdapter
Merged
jakzal
reviewed
Feb 9, 2017
| public static function throwOnRequiredClass($class) | ||
| { | ||
| $e = new \ReflectionException(sprintf('Class %s does not exist', $class)); | ||
| $e = new \ReflectionException("Class $class does not exist"); |
Contributor
There was a problem hiding this comment.
"Exception and error message strings must be concatenated using sprintf;" ;) http://symfony.com/doc/current/contributing/code/standards.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes HHVM, as spotted in #21527