Skip to content

Conversation

@ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented Feb 1, 2017

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

Fixes both array and iterator/closure-proxy arguments support in descriptors when using --show-arguments

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Feb 2, 2017
@ogizanagi ogizanagi changed the title [FrameworkBundle][Console] Fix descriptors to support IteratorArgument and arrays [FrameworkBundle][Console] Fix descriptors to support IteratorArgument, ClosureProxy and arrays Feb 2, 2017
@ogizanagi
Copy link
Contributor Author

PR updated to support ClosureProxyArgument too

@fabpot
Copy link
Member

fabpot commented Feb 2, 2017

Thank you @ogizanagi.

@fabpot fabpot merged commit a94924c into symfony:master Feb 2, 2017
fabpot added a commit that referenced this pull request Feb 2, 2017
…eratorArgument, ClosureProxy and arrays (ogizanagi)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[FrameworkBundle][Console] Fix descriptors to support IteratorArgument, ClosureProxy and arrays

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

Fixes both array and iterator/closure-proxy arguments support in descriptors when using `--show-arguments`

Commits
-------

a94924c [FrameworkBundle][Console] Fix descriptors to support IteratorArgument, ClosureProxy and arrays
@ogizanagi ogizanagi deleted the feature-fix/fwb/descr_iterator_args_and_arrays branch February 2, 2017 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants