[FrameworkBundle] Clean unnecessary method_exists calls in descriptors #21325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Oops I missed this one. The code can be more simplified: see #21341. |
Contributor
Author
|
Closing in favor of #21341 then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those checks look useless as soon as the FrameworkBundle v2.8 already requires the DI component 2.8 version in which were introduced these methods.
I also spotted the fact the
sharedproperty is missing from theTextDescriptor(at least should appear when a service is not shared IMHO) and theautowiringTypesare also missing from theXmlDescriptor.WDYT about fixing this here too, as a bug fix? Or should we actually consider the whole thing (clean + missing info in descriptors) as an enhancement and target master instead?