Fixed @return self with $this in FormConfigBuilderInterface
#21137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
👍 |
1 similar comment
Member
|
👍 |
Member
|
Thank you @wouterj. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 2, 2017
…terface (wouterj) This PR was merged into the 2.7 branch. Discussion ---------- Fixed `@return self` with `$this` in FormConfigBuilderInterface | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Fixes a tiny bug introduced by #21054 . `FormConfigBuilder` methods actually return `$this` and not `self`. This is important, as the `FormBuilder` (extending `FormConfigBuilder`) methods can also be called (e.g. `$builder->setDataMapper(...)->add()` is perfectly possible). Commits ------- 505e84d Fixed `@return self` with `$this`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a tiny bug introduced by #21054 .
FormConfigBuildermethods actually return$thisand notself. This is important, as theFormBuilder(extendingFormConfigBuilder) methods can also be called (e.g.$builder->setDataMapper(...)->add()is perfectly possible).