[FrameworkBundle] Deprecate the Templating component integration #21035

dunglas · 2016-12-23T15:56:38Z

Q	A
Branch?	master
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	yes
Tests pass?	yes
Fixed tickets	n/a
License	MIT
Doc PR	n/a

This PR deprecates the Templating component integration in FrameworkBundle. Only a few people use it because almost everybody use Twig or the serializer to output data. Removing this component will facilitate the maintenance.

stof · 2016-12-23T16:23:40Z

you also need to deprecate the TwigEngine (in the bridge and the bundle), as they are about integrating Twig in this component.

stof · 2016-12-23T16:24:15Z

And this requires deprecating the AppBundle:foo:bar.html.twig syntax too, as it comes from the Templating system (and this one is used)

dunglas · 2016-12-23T16:25:12Z

Do we want to deprecate this syntax or not?

stof · 2016-12-23T16:27:51Z

Well, if we don't want to deprecate it, you need to undeprecate the TemplateNameParser system in your PR.

mvrhov · 2016-12-23T17:59:02Z

The @AppBundle/foo/bar.html.twig syntax is recommended since 2.5 or something like that.
But deprecating the symfony specific syntax might show some resistance :P

dunglas · 2016-12-23T18:46:04Z

So let's deprecate this notation.

javiereguiluz · 2016-12-23T19:58:07Z

@dunglas last time we tried to deprecate that syntax (in June 2014) they almost killed us 😁 See #11051

By the way, in #20130 we discussed about a big inconsistency in the Twig syntax. Maybe we should take care of that too?

dunglas · 2016-12-23T20:20:03Z

@javiereguiluz but we have an advantage this time, people already using Twig alone (without the templating bridge) can only use the @AppBundle syntax. We're deprecating the Templating component, other syntaxes - not supported by the Twig Bundle - will be deprecated with it. Does it looks reasonable?

fabpot · 2016-12-23T20:23:03Z

Indeed, #11051 is very different. Here we are deprecating everything related to the Templating component, including the way we reference templates. There is no need to discuss how to reference templates as we are just using "pure" Twig, nothing more.

xabbuh · 2016-12-23T21:02:15Z

But I think we should indeed look into #20130 and try to find a way to resolve the inconsistency if we force everyone to use the Twig schema to reference templates.

xabbuh · 2016-12-28T17:13:05Z

One even more important thing: The native Twig namespace syntax as it is currently integrated in the framework fails on bundle inheritance (see #6919). Please take a look at #19586 which provides a fix.

chalasr · 2017-01-13T22:43:28Z

Should the TemplatingPass be deprecated?
Maybe should it trigger deprecations for each service in the loop too (i.e. tagged templating.*)?

dunglas · 2017-01-28T17:38:02Z

@chalasr good catch, done.

chalasr · 2017-02-03T21:48:28Z

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/TemplatingPass.php

        if ($container->hasDefinition('templating.engine.php')) {
            $helpers = array();
            foreach ($container->findTaggedServiceIds('templating.helper') as $id => $attributes) {
+                @trigger_error('The '.self::class.' class is deprecated since version 3.3 and will be removed in 4.0. Use Twig instead.', E_USER_DEPRECATED);


Wouldn't it be even better to have this deprecation only when using the class itself and trigger something like The "templating.helper" tag is deprecated as of 3.3... here instead?

nicolas-grekas · 2017-02-11T11:29:13Z

src/Symfony/Bridge/Twig/TwigEngine.php

 *
 * @author Fabien Potencier <fabien@symfony.com>
+ *
+ * @deprecated The TwigEngine class will be removed in Symfony 4.0. You should use \Twig_Environment directly instead.


@deprecated since version 3.3, to be removed in 4.0. Use Twig instead. (same below)

adrienrn · 2017-02-24T16:11:49Z

One question remains on my end : templating was giving a layer of abstraction to twig and if @templating goes away, do we need to inject @twig directly or some other component will provide an abstraction ?

nicolas-grekas · 2017-03-06T21:45:56Z

Status: needs work

fabpot · 2019-03-19T18:25:09Z

Thank you @dunglas.

…ntegration (dunglas, fabpot) This PR was merged into the 4.3-dev branch. Discussion ---------- [FrameworkBundle] Deprecate the Templating component integration | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a This PR deprecates the Templating component integration in FrameworkBundle. Only a few people use it because almost everybody use Twig or the serializer to output data. Removing this component will facilitate the maintenance. Commits ------- 7169f4d [Templating] added more deprecation 224c891 [FrameworkBundle] Deprecate the Templating component integration

dunglas · 2019-03-19T18:55:22Z

Thanks for finishing this!

javiereguiluz · 2019-03-27T15:19:38Z

I'm trying to make the doc changes for this. I have two questions:

Is using PHP templates (normal templates, form themes, etc) deprecated in 4.3 and will be removed in 5.0? If not, which are the steps needed to render PHP templates in 5.0?
What will happen with config like this? Is deprecated too? Is there an alternative?

        # config/packages/framework.yaml
        framework:
            # ...
            templating:
                hinclude_default_template: hinclude.html.twig

Thanks!

fabpot · 2019-03-29T16:11:50Z

@javiereguiluz

To answer your questions (and this is just my point of view):

Yes, we will remove support for the PHP form themes and other PHP template support in 5.0. If people want to keep using them, we will need to find volunteers to create a new PHPTemplateBundle that bundles all deprecated classes and support files.
We need to fix those and see where they belongs to now.

…javiereguiluz) This PR was squashed before being merged into the master branch (closes #11231). Discussion ---------- Documented the deprecation of the Templating component Documents symfony/symfony#21035 but there are some things I'm not sure about. Please, review. Commits ------- 57fadaf Documented the deprecation of the Templating component

… for PHP templating layer (yceruto) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle][TwigBundle] Add missing deprecations for PHP templating layer | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - As part of #21035 and 7169f4d Commits ------- 61613d0 Add missing deprecations for PHP templating layer

… for PHP templating layer (yceruto) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle][TwigBundle] Add missing deprecations for PHP templating layer | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - As part of symfony/symfony#21035 and symfony/symfony@7169f4d Commits ------- 61613d0bf0 Add missing deprecations for PHP templating layer

@fabpot

This PR was merged into the 5.0-dev branch. Discussion ---------- Removed support for PHP templating everywhere | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Ref: #21035 and 7169f4d **TODO:** Missing deprecations in 4.4 (#31800): - [x] `Symfony\Bundle\FrameworkBundle\Controller\TemplateController` 2nd argument. - [x] `Symfony\Bundle\TwigBundle\CacheWarmer\TemplateCacheCacheWarmer` class and service. **Labels:** `FrameworkBundle`, `TwigBundle`, `TwigBridge`, `SecurityBundle`, `Form`, `HttpKernel` Friendly ping @fabpot and @dunglas Commits ------- d5be373 Removed support for PHP templating everywhere

dunglas added the Templating label Dec 23, 2016

carsonbot added Status: Needs Review FrameworkBundle Deprecation labels Dec 23, 2016

dunglas mentioned this pull request Dec 23, 2016

[Templating] Deprecate the component #21036

Closed

nicolas-grekas added this to the 3.3 milestone Dec 26, 2016

dunglas force-pushed the deprecate_templating_fwb branch from 84512fd to 942e80b Compare January 10, 2017 22:35

wesleylancel mentioned this pull request Jan 18, 2017

[ALL] updated twig includes to correct convention Kunstmaan/KunstmaanBundlesCMS#1436

Merged

dunglas force-pushed the deprecate_templating_fwb branch from 942e80b to b4c2b91 Compare January 28, 2017 17:32

dunglas force-pushed the deprecate_templating_fwb branch from ac6ec3b to 3320f5f Compare February 3, 2017 20:13

chalasr reviewed Feb 3, 2017

View reviewed changes

dunglas force-pushed the deprecate_templating_fwb branch from c03495c to 1086047 Compare February 5, 2017 18:59

nicolas-grekas reviewed Feb 11, 2017

View reviewed changes

dunglas force-pushed the deprecate_templating_fwb branch 2 times, most recently from b0ef3c6 to 245ffd0 Compare February 13, 2017 13:12

fabpot force-pushed the deprecate_templating_fwb branch 5 times, most recently from 248a9c0 to 71683bd Compare March 19, 2019 17:10

[FrameworkBundle] Deprecate the Templating component integration

224c891

fabpot force-pushed the deprecate_templating_fwb branch 3 times, most recently from 9c96d27 to 715b7d9 Compare March 19, 2019 17:48

[Templating] added more deprecation

7169f4d

fabpot force-pushed the deprecate_templating_fwb branch from 715b7d9 to 7169f4d Compare March 19, 2019 17:58

fabpot merged commit 7169f4d into symfony:master Mar 19, 2019

javiereguiluz mentioned this pull request Mar 27, 2019

Documented the deprecation of the Templating component symfony/symfony-docs#11231

Closed

javiereguiluz mentioned this pull request Apr 5, 2019

Provide alternative config options for deprecated templating options #30874

Closed

chalasr mentioned this pull request Apr 9, 2019

DI-test-autowiring lexik/LexikCronFileGeneratorBundle#2

Merged

nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

fabpot mentioned this pull request May 9, 2019

Release v4.3.0-BETA1 #31435

Merged

This was referenced Jun 3, 2019

Removed support for PHP templating everywhere #31800

Merged

[FrameworkBundle][TwigBundle] Add missing deprecations for PHP templating layer #31821

Merged

Simperfit mentioned this pull request Jun 20, 2019

UPGRADE to Symfony 4.3 missing helpful documentation #32120

Closed

Uh oh!

[FrameworkBundle] Deprecate the Templating component integration #21035

[FrameworkBundle] Deprecate the Templating component integration #21035

Uh oh!

Conversation

dunglas commented Dec 23, 2016 • edited by nicolas-grekas Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stof commented Dec 23, 2016

Uh oh!

stof commented Dec 23, 2016

Uh oh!

dunglas commented Dec 23, 2016

Uh oh!

stof commented Dec 23, 2016

Uh oh!

mvrhov commented Dec 23, 2016

Uh oh!

dunglas commented Dec 23, 2016

Uh oh!

javiereguiluz commented Dec 23, 2016

Uh oh!

dunglas commented Dec 23, 2016

Uh oh!

fabpot commented Dec 23, 2016

Uh oh!

xabbuh commented Dec 23, 2016

Uh oh!

xabbuh commented Dec 28, 2016

Uh oh!

chalasr commented Jan 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dunglas commented Jan 28, 2017

Uh oh!

chalasr Feb 3, 2017

Choose a reason for hiding this comment

Uh oh!

nicolas-grekas Feb 11, 2017

Choose a reason for hiding this comment

Uh oh!

adrienrn commented Feb 24, 2017

Uh oh!

nicolas-grekas commented Mar 6, 2017

Uh oh!

fabpot commented Mar 19, 2019

Uh oh!

dunglas commented Mar 19, 2019

Uh oh!

javiereguiluz commented Mar 27, 2019

Uh oh!

fabpot commented Mar 29, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

dunglas commented Dec 23, 2016 •

edited by nicolas-grekas

Loading

chalasr commented Jan 13, 2017 •

edited

Loading