[HttpFoundation] Improved set cookie header tests #20972
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
changed the title
fabpot
reviewed
Dec 19, 2016
| ); | ||
| } | ||
|
|
||
| protected function assertSetCookieHeader($expected, ResponseHeaderBag $actual) |
Contributor
Author
|
@fabpot changed to private and should get in master as well 👍 |
Member
|
👍 |
Member
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Jan 6, 2017
This PR was squashed before being merged into the 2.7 branch (closes #20972). Discussion ---------- [HttpFoundation] Improved set cookie header tests | Q | A | ------------- | --- | Branch? | 2.7 (already in master) | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> Separated from #20569 Commits ------- 05bce71 [HttpFoundation] Improved set cookie header tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated from #20569