[WebProfilerBundle] add dependency on Twig #20840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requiring a specific minimum version of the TwigBridge just to be sure that we end up with the required Twig version does not make much sense if can simply specify the required version instead (we do in fact depend on Twig in the WebProfilerBundle).
Member
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Dec 9, 2016
This PR was merged into the 2.7 branch. Discussion ---------- [WebProfilerBundle] add dependency on Twig | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20802 | License | MIT | Doc PR | Requiring a specific minimum version of the TwigBridge just to be sure that we end up with the required Twig version does not make much sense if can simply specify the required version instead (we do in fact depend on Twig in the WebProfilerBundle). Commits ------- 91689a7 add dependency on Twig
This was referenced Dec 13, 2016
Merged
Merged
Merged
Merged
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
This PR was merged into the 2.7 branch. Discussion ---------- [WebProfilerBundle] add dependency on Twig | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#20802 | License | MIT | Doc PR | Requiring a specific minimum version of the TwigBridge just to be sure that we end up with the required Twig version does not make much sense if can simply specify the required version instead (we do in fact depend on Twig in the WebProfilerBundle). Commits ------- 91689a7 add dependency on Twig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring a specific minimum version of the TwigBridge just to be sure
that we end up with the required Twig version does not make much sense
if can simply specify the required version instead (we do in fact depend
on Twig in the WebProfilerBundle).