[Yaml] Clean some messages + add test case #20388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuilhemN
reviewed
Nov 2, 2016
| */ | ||
| public function testStringOffsetCastError() | ||
| { | ||
| Inline::parse('{this, is not, yaml}'); |
Contributor
There was a problem hiding this comment.
This is valid yaml, to not confuse people what about {this, is, not, supported}?
nicolas-grekas
force-pushed
the
yaml-clean
branch
from
91e38be to
7520f7b
Compare
fabpot
reviewed
Nov 2, 2016
| $i += strlen($output); | ||
| } else { | ||
| throw new ParseException(sprintf('Malformed inline YAML string (%s).', $scalar)); | ||
| throw new ParseException(sprintf('Malformed inline YAML string: %s.', $scalar)); |
Member
There was a problem hiding this comment.
this avoids confusion, especially in case the YAML string contains unbalanced braces
Member
Author
There was a problem hiding this comment.
also for consistency: some messages had brackets+final dot around, others not.
Member
There was a problem hiding this comment.
yeah, messages without brackets were changed in the past precisely for the reason I gave. Looks like messages added in newer branches were not updated after the branch merge
Member
|
👍 |
Member
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 2, 2016
This PR was merged into the 2.7 branch. Discussion ---------- [Yaml] Clean some messages + add test case | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Related to #20335 on 3.2. Commits ------- 7520f7b [Yaml] Clean some messages + add test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #20335 on 3.2.