[Console] simplified code #20372
Merged
[Console] simplified code #20372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
that referenced
this pull request
Oct 31, 2016
This PR was merged into the 2.8 branch. Discussion ---------- [Console] simplified code | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | ~no~ yes (even if the output is "better" with this PR) | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Instead of adding blank character for shorter lines and having to keep the max length of messages, I propose to clear the line via an ANSI sequence like done in the progress bar. Code is cleaner and output is better as currently, then cursor can be "away" from the last character which is unexpected. Actually, this is a bug fix as the current code does not work well when using styles in the indicator message. Commits ------- 0aca9bf [Console] simplified code
This was referenced Nov 17, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noyes (even if the output is "better" with this PR)Instead of adding blank character for shorter lines and having to keep the max length of messages, I propose to clear the line via an ANSI sequence like done in the progress bar.
Code is cleaner and output is better as currently, then cursor can be "away" from the last character which is unexpected.
Actually, this is a bug fix as the current code does not work well when using styles in the indicator message.