Use "more entropy" option for uniqid() #20132
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i found some other usages without more entropy option:
|
Member
Author
Member
|
👍 |
Member
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
Oct 3, 2016
This PR was squashed before being merged into the 2.7 branch (closes #20132). Discussion ---------- Use "more entropy" option for uniqid() | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - As you can see in [the source code of the PHP uniqid() function](https://github.com/php/php-src/blob/1c295d4a9ac78fcc2f77d6695987598bb7abcb83/ext/standard/uniqid.c#L68) when you don't pass `true` as the second argument, PHP sleeps the application for 1 microsecond (`usleep(1)`) Symfony uses `true` almost everywhere, but there are still some places (mostly in bundles) where this is not the case. Commits ------- 4403e28 Use "more entropy" option for uniqid()
fabpot
added a commit
that referenced
this pull request
Oct 3, 2016
This PR was merged into the 3.2-dev branch. Discussion ---------- Add "more entropy" to every uniqid() call | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Same as #20132 but for the master branch Commits ------- 50a8c1f Add "more entropy" to every uniqid() call
This was referenced Oct 3, 2016
Merged
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Jul 10, 2024
This PR was merged into the 5.4 branch. Discussion ---------- use more entropy with uniqid() | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT It looked like using `uniqid()` without opting for more entropy slipped in after #20132 and #20137. Commits ------- 770e7fc use more entropy with uniqid()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you can see in the source code of the PHP uniqid() function when you don't pass
trueas the second argument, PHP sleeps the application for 1 microsecond (usleep(1))Symfony uses
truealmost everywhere, but there are still some places (mostly in bundles) where this is not the case.