-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[Console] Different approach on merging application definition #20054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
So.. any thoughts on this? I think this is way more obvious than the current approach. The list command not giving the application-wide options is a bug.. right? However they were more or less explicitly left out... any opinion on this? edit: yeah.. after #20090 and rebase 2.7 imo. |
|
Not sure about intentions here. It's done rather explicitly. The global options do work though with |
|
Tested the changes on 3.4 and this approach seems to be working properly. |
|
status: needs work |
|
@ro0NL I'm digging the old PRs right now and stumbled on this one. I see that you marked it as "Needs work", is it still relevant? |
|
@fabpot i'd say yes. It boils down to Not sure why i marked it "needs work" 😅 i figure to come to some sort of conslusion here. |
|
Ok, can you rebase on current master? I will test it on a real application to see how it behaves. |
|
@fabpot should be good. |
|
@fabpot console component passes tests 👍 |
fabpot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
|
Thank you @ro0NL. |
Before/After:
$ bin/console list -h Usage: list [options] [--] [<namespace>] Arguments: namespace The namespace name Options: --raw To output raw command list --format=FORMAT The output format (txt, xml, json, or md) [default: "txt"] + -h, --help Display this help message + -q, --quiet Do not output any message + -V, --version Display this application version + --ansi Force ANSI output + --no-ansi Disable ANSI output + -n, --no-interaction Do not ask any interactive question + -e, --env=ENV The environment name [default: "dev"] + --no-debug Switches off debug mode + -v|vv|vvv, --verbose Increase the verbosity of messages: 1 for normal output, 2 for more verbose output and 3 for debug Help: The list command lists all commands: php bin/console list You can also display the commands for a specific namespace: php bin/console list test You can also output the information in other formats by using the --format option: php bin/console list --format=xml It's also possible to get raw list of commands (useful for embedding command runner): php bin/console list --rawThis could deprecate
getNativeDefinitionor make it a feature as right now it's internal and unused.edit: resolved the BC break.
edit2: question is.. should this target 2.7?