[VarDumper] Use ClassStub for reflected types #19987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It doesn't seem to fix the SecurityBundle tests (should it?). |
Member
Author
|
@jakzal this is because of per-component tests: the patch here is not used on the SecurityBundle test suite because SecurityBundle is untouched by the PR. This a corner case. But as far as I tested correctly on my machine, it will make tests green yes. |
Member
Author
|
Oh, and the PR that should fix tests is #19986, not this one :) |
nicolas-grekas
force-pushed
the
dump-fix
branch
from
62810a3 to
68536da
Compare
nicolas-grekas
force-pushed
the
dump-fix
branch
from
68536da to
e2b2c9b
Compare
Member
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Sep 21, 2016
…-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [VarDumper] Use ClassStub for reflected types | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - The implementation ensures that type hints do not trigger autoloading by `ClassStub` itself. Commits ------- e2b2c9b [VarDumper] Use ClassStub for reflected types
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation ensures that type hints do not trigger autoloading by
ClassStubitself.