[Validator] Allow Choice Constraint Callback to be non-static #19959
+20
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-mcdougle
changed the title
Contributor
Author
|
@webmozart Travis failure seems unrelated. What do you think? |
Member
|
👍 |
Contributor
|
Duplicate of #19745 😭 |
Contributor
Author
|
@ro0NL 😭 indeed. I totally didn't notice that. Someone should merge that one instead. |
Contributor
|
I know the feeling. And yes.. it totally feels like feature-freeze right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that as of 3.0 the ExecutionContextInterface has a getObject method, the callback doesn't need to be static anymore, it can actually be on the object that's being validated. This is great because you can actually have dynamic choices and this validator will actually work. Maintainers are free to add commits to this branch.