Skip to content

[Yaml] Port of #19922 for 3.2 #19940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabpot merged 1 commit into from
Sep 15, 2016
Merged

[Yaml] Port of #19922 for 3.2 #19940

fabpot merged 1 commit into from
Sep 15, 2016

Conversation

@chalasr
Copy link
Member

@chalasr chalasr commented Sep 14, 2016

Q A
Branch? master
Tests pass? yes
License MIT

The command has been moved in 3.2 so the new path is unmerged.

fabpot
fabpot reviewed Sep 14, 2016
View reviewed changes
src/Symfony/Component/Yaml/Command/LintCommand.php Outdated
});

$io->writeln(json_encode($filesInfo, JSON_PRETTY_PRINT));
$output->writeln(json_encode($filesInfo, JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES));
Copy link
Member

@fabpot fabpot Sep 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be $io, right?

Copy link
Member Author

@chalasr chalasr Sep 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@chalasr chalasr force-pushed the lint_json_unescaped_slashes_3.2 branch from 858c7d2 to 017e88b Compare September 14, 2016 23:17
@javiereguiluz
Copy link
Member

javiereguiluz commented Sep 15, 2016

👍

Status: Reviewed

@fabpot
Copy link
Member

fabpot commented Sep 15, 2016

Thank you @chalasr.

@fabpot fabpot merged commit 017e88b into symfony:master Sep 15, 2016
fabpot added a commit that referenced this pull request Sep 15, 2016
@fabpot
minor #19940 [Yaml] Port of #19922 for 3.2 (chalasr)
c6f6e05 
This PR was merged into the 3.2-dev branch.

Discussion
----------

[Yaml] Port of #19922 for 3.2

| Q             | A
| ------------- | ---
| Branch?       | master
| Tests pass?   | yes
| License       | MIT

The command has been moved in 3.2 so the new path is unmerged.

Commits
-------

017e88b [Yaml] Port of #19922 for 3.2
@chalasr chalasr deleted the lint_json_unescaped_slashes_3.2 branch September 15, 2016 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabpot fabpot fabpot left review comments

Assignees

No one assigned

Labels

Status: Reviewed Yaml

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chalasr @javiereguiluz @fabpot @carsonbot