Fixed bad merge #19932
Closed
Fixed bad merge #19932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GrahamCampbell
commented
Sep 13, 2016
GrahamCampbell
commented
| Q | A |
|---|---|
| Branch? | 3.1 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| License | MIT |
Contributor
Author
|
I did actually flag this as a point to be careful with when merging in #19813 (comment). |
:P
Contributor
Author
|
I guess maybe 2.8 is the place to fix this rather than 3.1. :) |
Member
|
Thank you @GrahamCampbell. |
fabpot
added a commit
that referenced
this pull request
Sep 13, 2016
This PR was submitted for the 3.1 branch but it was merged into the 2.8 branch instead (closes #19932). Discussion ---------- Fixed bad merge | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Commits ------- d30374d Fixed bad merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.