Skip to content

Conversation

@mbeccati
Copy link
Contributor

@mbeccati mbeccati commented Sep 7, 2016

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #19721
License MIT
Doc PR n.a.

Issue was introduced in #19541

@Jean85
Copy link
Contributor

Jean85 commented Sep 7, 2016

LGTM 👍

Status: reviewed

@nicolas-grekas nicolas-grekas changed the title Fix #19721 [Form] Incorrect timezone result of DateTimeLocalizedStringTransformer Sep 7, 2016
@nicolas-grekas nicolas-grekas changed the title [Form] Incorrect timezone result of DateTimeLocalizedStringTransformer [Form] Incorrect timezone with DateTimeLocalizedStringTransformer Sep 7, 2016
$transformer = new DateTimeToLocalizedStringTransformer();

$this->assertEquals(
(new \DateTime('2010-02-03 04:05'))->format('c'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid syntax on PHP 5.3 (as seen on test failures)

Issue was introduced in #19541
@nicolas-grekas
Copy link
Member

👍

1 similar comment
@jakzal
Copy link
Contributor

jakzal commented Sep 8, 2016

👍

@fabpot
Copy link
Member

fabpot commented Sep 8, 2016

Thank you @mbeccati.

@fabpot fabpot merged commit bf6691c into symfony:2.7 Sep 8, 2016
fabpot added a commit that referenced this pull request Sep 8, 2016
…sformer (mbeccati)

This PR was merged into the 2.7 branch.

Discussion
----------

[Form] Incorrect timezone with DateTimeLocalizedStringTransformer

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #19721
| License       | MIT
| Doc PR        | n.a.

Issue was introduced in #19541

Commits
-------

bf6691c Fix #19721
@mbeccati mbeccati deleted the 19721-datetype-fix-27 branch September 8, 2016 15:05
This was referenced Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants