[HttpKernel][EventDispatcher] Wrap some log contexts with ClassStub #19829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will be useful when #19614 will be merged to get more detailed log contexts in the "Logs" profiler panel.
This screenshot has been taken with both branches checked out at the same time:
Since
ClassStubimplements__toString, contexts are logged as e.g.request.INFO: Matched route "{route}". {"route":"app_lucky_number","route_parameters":{"_controller": "[object] (Symfony\\Component\\VarDumper\\Caster\\ClassStub: AppBundle\\Controller\\LuckyController::numberAction)","_route": "app_lucky_number"},"request_uri":"http://127.0.0.1:8000/lucky/number","method":"GET"} []by Monolog's NormalizerFormatter.Seldaek/monolog#843 or some variant of it should fix this back to a plain string.