[Config] Add ExprBuilder::ifEmpty() #19764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @return ExprBuilder | ||
| */ | ||
| public function ifEmpty() | ||
| { |
Member
There was a problem hiding this comment.
having the same behavior than empty($v) is fine with me. If we do something else, we should change the name away from ifEmpty to avoid WTF moments IMO
Contributor
Author
There was a problem hiding this comment.
As @stof said, it isn't an issue to me, because anyone using it must understand it behaves like its php empty function counterpart, and know the limitations.
Otherwise, we have to rename it to isEmptyArray, or whatever, but right now I think the expression builder should stick with simple expressions like this.
If you really expect '', false, null, '0' or 0 to be valid for your node, you shouldn't use ifEmpty.
Member
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Aug 31, 2016
This PR was merged into the 3.2-dev branch. Discussion ---------- [Config] Add ExprBuilder::ifEmpty() | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#6922 Useful for instance when you don't expect to have a key set in the resolved config if its content is empty: ```php $builder = new TreeBuilder(); $tree = $builder ->root('matcher') ->children() ->arrayNode('references_to_exclude') ->validate() ->ifEmpty() ->thenUnset() ->end() ->prototype('scalar')->end() ->end() ->end() ->end() ->buildTree() ; $tree->finalize(['references_to_exclude' => ['foo', 'bar']]); >>> ['references_to_exclude' => ['foo', 'bar']] $tree->finalize(['references_to_exclude' => []]); >>> [] ``` Commits ------- 4e46f64 [Config] Add ExprBuilder::ifEmpty()
weaverryan
added a commit
to symfony/symfony-docs
that referenced
this pull request
Sep 18, 2016
This PR was merged into the master branch. Discussion ---------- [Config] Add ExprBuilder::ifEmpty() After symfony/symfony#19764 Commits ------- f0fe739 [WCM][Config] Add ExprBuilder::ifEmpty()
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for instance when you don't expect to have a key set in the resolved config if its content is empty: