[SecurityBundle] Add missing deprecation notice for form_login.intention #19667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Manually checked out and it fixed it 👍 |
Contributor
Author
|
I dont know wtf is going on.. (github? fabpot?).. but #19662 was removed.. now it's back. Anyway, for reference :-) |
Member
|
I thought the owner has been banned and the related issues/PRs too... |
Contributor
Author
|
Me too, but in case of no censor; 👍 |
Member
|
👍 for 2.8 since this is not really a new deprecation but rather a bc-break fix. |
nicolas-grekas
changed the title
Member
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Aug 19, 2016
…ogin.intention (ro0NL) This PR was squashed before being merged into the 2.8 branch (closes #19667). Discussion ---------- [SecurityBundle] Add missing deprecation notice for form_login.intention | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #19664, #19661, #19652 | License | MIT | Doc PR | - By the grace of @chalasr ping @fabpot Commits ------- 2a7bbd1 [SecurityBundle] Add missing deprecation notice for form_login.intention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By the grace of @chalasr
ping @fabpot