[Cache] Use SCAN instead of KEYS with Redis >= 2.8 #19551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
cache-redis-clear
branch
4 times, most recently
from
bf57c04 to
3a07ff2
Compare
nicolas-grekas
force-pushed
the
cache-redis-clear
branch
from
3a07ff2 to
aadeb11
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Aug 7, 2016
…s-grekas) This PR was merged into the 3.1 branch. Discussion ---------- [Cache] Use SCAN instead of KEYS with Redis >= 2.8 | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - With #19521 coming, clearing cache keys by prefix is going to be used a lot more often. Time to fix Redis cache clearing. Commits ------- aadeb11 [Cache] Use SCAN instead of KEYS with Redis >= 2.8
| $info = $host->info('Server'); | ||
| $info = isset($info['Server']) ? $info['Server'] : $info; | ||
|
|
||
| if (!version_compare($info['redis_version'], '2.8', '>=')) { |
Contributor
There was a problem hiding this comment.
Just for curiosity, can't you do: version_compare($info['redis_version'], '2.8', '<') ?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #19521 coming, clearing cache keys by prefix is going to be used a lot more often.
Time to fix Redis cache clearing.