[Yaml] update changelog and upgrade files #19538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Aug 4, 2016
xabbuh
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #19504 |
| License | MIT |
| Doc PR |
Member
|
👍 The message that you propose is technically correct ... but I think we could make it easier to understand. If you agree, I was thinking something like the following: |
Member
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Aug 13, 2016
This PR was merged into the 3.2-dev branch. Discussion ---------- [Yaml] update changelog and upgrade files | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19504 | License | MIT | Doc PR | Commits ------- 3cd2932 [Yaml] update changelog and upgrade files
fabpot
added a commit
that referenced
this pull request
Aug 27, 2016
This PR was merged into the 3.2-dev branch. Discussion ---------- [Yaml] improve changelog and upgrade entries | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? |no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Improves the wording as suggested by @javiereguiluz in #19538 (comment). Commits ------- e288256 [Yaml] improve changelog and upgrade entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.