Skip to content

[Form] Fixed prototype inheritance in CollectionType #19420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
HeahDude wants to merge 1 commit into from
Closed

[Form] Fixed prototype inheritance in CollectionType #19420

HeahDude wants to merge 1 commit into from

Conversation

@HeahDude
Copy link
Contributor

@HeahDude HeahDude commented Jul 25, 2016

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #19355
License MIT
Doc PR ~

@HeahDude HeahDude mentioned this pull request Jul 25, 2016
Closed
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jul 25, 2016

A test case please?

@HeahDude
Copy link
Contributor Author

HeahDude commented Jul 25, 2016

@nicolas-grekas introduced in #18317 and still green :)

@HeahDude
Copy link
Contributor Author

HeahDude commented Jul 26, 2016

I don't think this PR should be merge, closing.

@HeahDude HeahDude closed this Jul 26, 2016
@HeahDude HeahDude deleted the fix/form-prototype_parent branch November 24, 2018 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug Form Status: Needs Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HeahDude @nicolas-grekas @carsonbot