[VarDumper] Dumping exceptions is now more compact #19289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
👍 This looks much better. Thanks Nicolas! I'd also suggest to not use 1-letter variable names because it makes code hard to understand and maintain in the long term. |
nicolas-grekas
force-pushed
the
dump-compact
branch
2 times, most recently
from
6776dd0 to
01dfc6c
Compare
Member
Author
|
New "after": |
| $call = isset($frames[$i]['function']) ? (isset($frames[$i]['class']) ? $frames[$i]['class'].$frames[$i]['type'] : '').$frames[$i]['function'].'()' : '???'; | ||
|
|
||
| $a[Caster::PREFIX_VIRTUAL.$j.'. '.$call.$lastCall] = new FrameStub( | ||
| $k = $call.$lastCall; |
Member
There was a problem hiding this comment.
please rename these variables to more meaningful names
nicolas-grekas
force-pushed
the
dump-compact
branch
5 times, most recently
from
514ad94 to
90fd3b0
Compare
| foreach ($frame->value as $label => $frame) { | ||
| } | ||
| } else { | ||
| $label = ''; |
Contributor
There was a problem hiding this comment.
Can this statement be moved before the if condition to prevent the else statement?
Member
Author
There was a problem hiding this comment.
updated, no need for any if/else in fact
nicolas-grekas
force-pushed
the
dump-compact
branch
from
90fd3b0 to
9a2160d
Compare
Member
Author
|
ping @symfony/deciders |
Member
Author
|
Status: needs work |
nicolas-grekas
force-pushed
the
dump-compact
branch
from
9a2160d to
51547b7
Compare
Member
Author
|
Updated to be compact also when args are dumped. Test cases added. Status: needs review |
nicolas-grekas
force-pushed
the
dump-compact
branch
from
51547b7 to
19e9cbe
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Jul 28, 2016
…colas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [VarDumper] Dumping exceptions is now more compact | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | - | License | MIT | Doc PR | - Before:  Commits ------- 19e9cbe [VarDumper] Dumping exceptions is now more compact
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
