[FrameworkBundle] Show server:run logs by default #19174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
added
the
DX
| $process->setTty(true); | ||
| } | ||
| $process->run(); | ||
| } catch (RuntimeException $e) { |
Member
There was a problem hiding this comment.
couldn't runtime exceptions happen for other reasons than unsupported tty mode during $process->run();, causing weird cases of running the process twice ?
Member
Author
There was a problem hiding this comment.
let's be safe, fixed
nicolas-grekas
force-pushed
the
server-log
branch
from
7536e8b to
691fa9c
Compare
| $process->disableOutput(); | ||
| try { | ||
| if (OutputInterface::VERBOSITY_NORMAL > $output->getVerbosity()) { | ||
| $process->disableOutput(); |
Member
There was a problem hiding this comment.
do we need to have this inside the try/catch ?
Member
Author
There was a problem hiding this comment.
no but we need to have this if/else logic so code is easier this way
Member
There was a problem hiding this comment.
the try/cache can be inside the else (and defining $callback = null; before the if)
nicolas-grekas
force-pushed
the
server-log
branch
from
691fa9c to
7cc6161
Compare
Member
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jun 30, 2016
…olas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [FrameworkBundle] Show server:run logs by default | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I propose to change the default for the `server:run` command and show `php -S` logs by default. I really miss them otherwise. The `-vvv` mode is not suited here, because it adds a useless ` ERR ` red prefix. I do this through a tty when available, so that the output remains colored. Ping @javiereguiluz @weaverryan since this is mostly a DX issue. Commits ------- 7cc6161 [FrameworkBundle] Show server:run logs by default
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to change the default for the
server:runcommand and showphp -Slogs by default.I really miss them otherwise. The
-vvvmode is not suited here, because it adds a uselessERRred prefix.I do this through a tty when available, so that the output remains colored.
Ping @javiereguiluz @weaverryan since this is mostly a DX issue.