[Validator] support egulias/email-validator 2.x #19153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jun 23, 2016
xabbuh
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
| array('"test".test@iana.org'), | ||
| array('"test"' . chr(0) . '@iana.org'), | ||
| array('"test\"@iana.org'), | ||
| array(chr(226) . '@iana.org'), |
Member
There was a problem hiding this comment.
spaces around . should be removed
xabbuh
force-pushed
the
email-validator-2.0-support
branch
from
783cbc7 to
7a9c231
Compare
xabbuh
force-pushed
the
email-validator-2.0-support
branch
from
7a9c231 to
25d39aa
Compare
Member
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jun 23, 2016
This PR was merged into the 3.2-dev branch. Discussion ---------- [Validator] support egulias/email-validator 2.x | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 25d39aa support egulias/email-validator 2.x
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.