[Cache] Fix double fetch in ProxyAdapter #19042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Jun 13, 2016
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 3.1 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
| private $isHit; | ||
| private $expiry; | ||
| private $defaultLifetime; | ||
| protected $key; |
Member
Author
There was a problem hiding this comment.
Since the class is final, changing to protected here has no bc-promise-related impact.
Member
There was a problem hiding this comment.
what is the goal of using protected visibility in a final class ?
Member
Author
There was a problem hiding this comment.
shorter code, and const removal (to be sure nobody will use it)
Contributor
There was a problem hiding this comment.
I think @stof meant that you could keep it private, since no other classes could possibly exist to access it.
nicolas-grekas
force-pushed
the
cache-proxy
branch
from
89ba542 to
040f53d
Compare
Member
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jun 14, 2016
This PR was merged into the 3.1 branch. Discussion ---------- [Cache] Fix double fetch in ProxyAdapter | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 040f53d [Cache] Fix double fetch in ProxyAdapter
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.