[Serializer] AbstractObjectNormalizer: be sure that isAllowedAttribute is called #18837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@dunglas So this is meant to be merged into the |
Member
Author
|
Yes |
Member
|
Merging as I'd like to do RC1 today. A test can/should be added later on. |
Member
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
May 24, 2016
…wedAttribute is called (dunglas) This PR was submitted for the master branch but it was merged into the 3.1 branch instead (closes #18837). Discussion ---------- [Serializer] AbstractObjectNormalizer: be sure that isAllowedAttribute is called | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Please merge before the release of 3.1 (potential bug fix) Commits ------- 29b4115 [Serializer] AbstractObjectNormalizer: be sure that isAllowedAttribute is called
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
May 25, 2016
fabpot
added a commit
that referenced
this pull request
May 26, 2016
This PR was merged into the 3.1 branch. Discussion ---------- [Serializer][#18837] adding a test | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18837 | License | MIT | Doc PR | Commits ------- 37cacc4 [Serializer][#18837] adding a test
fabpot
added a commit
that referenced
this pull request
May 26, 2016
* 3.1: [Console] SymfonyStyle: Align multi-line/very-long-line blocks [Console][DX] Fixed ambiguous error message when using a duplicate option shortcut Fix js comment in profiler [Ldap] Fixed issue with Entry password attribute containing array of values and made password attribute configurable [Serializer][#18837] adding a test [Cache] Drop counting hit/miss in ProxyAdapter [Serializer] AbstractObjectNormalizer: be sure that isAllowedAttribute is called [Serializer] ObjectNormalizer: add missing parameters
Merged
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
* 3.1: [Console] SymfonyStyle: Align multi-line/very-long-line blocks [Console][DX] Fixed ambiguous error message when using a duplicate option shortcut Fix js comment in profiler [Ldap] Fixed issue with Entry password attribute containing array of values and made password attribute configurable [Serializer][symfony#18837] adding a test [Cache] Drop counting hit/miss in ProxyAdapter [Serializer] AbstractObjectNormalizer: be sure that isAllowedAttribute is called [Serializer] ObjectNormalizer: add missing parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please merge before the release of 3.1 (potential bug fix)