[Bridge/Doctrine] Use better exception in the register mapping pass #18654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantleech
force-pushed
the
better_exceptoin_mapping_pass
branch
from
e1591da to
07c46b0
Compare
dantleech
changed the title
dantleech
force-pushed
the
better_exceptoin_mapping_pass
branch
from
07c46b0 to
a513f47
Compare
- When no manager name parameter found, throw a more informative exception.
dantleech
force-pushed
the
better_exceptoin_mapping_pass
branch
from
a513f47 to
0eeedee
Compare
| } | ||
|
|
||
| throw new ParameterNotFoundException('Could not determine the Doctrine manager. Either Doctrine is not configured or a bundle is misconfigured.'); | ||
| throw new \InvalidArgumentException(sprintf( |
Contributor
Author
There was a problem hiding this comment.
- This is potentially a BC break if anybody was depending on the
ParameterNotFoundExceptionfor any reason. - Should this be a
DependencyInjection\Exception\InvalidArgumentExceptionor similar?
Member
|
@dantleech we prefer doing this kind of changes on master because of the potential BC break you spotted... |
Contributor
Author
|
Looks like I already based it on master by accident. |
javiereguiluz
added
DX
Member
|
Thank you @dantleech. |
fabpot
added a commit
that referenced
this pull request
May 13, 2016
… mapping pass (dantleech) This PR was merged into the 3.1-dev branch. Discussion ---------- [Bridge/Doctrine] Use better exception in the register mapping pass | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no/yes ? | Deprecations? | no | Tests pass? | ? | Fixed tickets | | License | MIT | Doc PR | Current when this mapping pass cannot find (any of) the configured managers the user receives the following exception: ``` [Symfony\Component\DependencyInjection\Exception\ParameterNotFoundException] You have requested a non-existent parameter "Could not determine the Doctrine manager. Either Doctrine is not configured or a bundle is misconfigured.". ``` Which is misleading and strange. This PR changes the exception to an `InvalidArgumentException` and provides the following message: ``` [InvalidArgumentException] Could not find the object manager name parameter. Tried: "cmf_routing.dynamic.persistence.orm.manager_name", "doctrine.default_entity_manager" ``` Commits ------- 0eeedee Use better exception in the register mapping pass
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current when this mapping pass cannot find (any of) the configured managers the user receives the following exception:
Which is misleading and strange.
This PR changes the exception to an
InvalidArgumentExceptionand provides the following message: