Replace iconv_*() uses by mb_*(), add mbstring polyfill when required #18540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
mbstring
branch
from
02d2e2b to
0aaad48
Compare
nicolas-grekas
force-pushed
the
mbstring
branch
from
0aaad48 to
27f5f81
Compare
Member
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Apr 15, 2016
…en required (nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- Replace iconv_*() uses by mb_*(), add mbstring polyfill when required | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18539 | License | MIT | Doc PR | - Looks like `iconv_*()` functions can be really slow (see #18539). Commits ------- 27f5f81 Replace iconv_*() uses by mb_*(), add mbstring polyfill when required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like
iconv_*()functions can be really slow (see #18539).