Skip to content

[FrameworkBundle] Upgrade notice for the Controller::json() method #18373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabpot merged 1 commit into from
Apr 5, 2016
+5 −0
Merged

[FrameworkBundle] Upgrade notice for the Controller::json() method #18373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions UPGRADE-3.1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ FrameworkBundle
* As it was never an officially supported feature, the support for absolute
template paths has been deprecated and will be removed in Symfony 4.0.

* The abstract `Controller` class now has a `json()` helper method that creates
Copy link
Contributor

@HeahDude HeahDude Apr 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing empty line :)

a `JsonResponse`. If you have existing controllers extending `Controller`
that contain a method with this name, you need to rename that method to avoid
conflicts.
Copy link
Contributor

@HeahDude HeahDude Apr 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it might be a BC break, right ?
Just read the description of the PR


* The following form types registered as services have been deprecated and
will be removed in Symfony 4.0; use their fully-qualified class name instead:

Expand Down