[Form] Remove unused legacy code in ChoiceType
#18299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeahDude
commented
Mar 24, 2016
HeahDude
commented
| Q | A |
|---|---|
| Branch? | 3.0 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | - |
HeahDude
force-pushed
the
minor-choice_type-unused_code
branch
from
c9358b2 to
8af78e9
Compare
| $options['group_by'] = !$options['choices_as_values'] | ||
| ? self::flipRecursive($options['choices']) | ||
| : $options['choices']; | ||
| $options['group_by'] = $options['choices']; |
Member
There was a problem hiding this comment.
What if someone still uses the choices_as_values option?
Contributor
Author
There was a problem hiding this comment.
@xabbuh Thanks for the review.
choices_as_values is normalized to true since 3.0 and deprecated in 3.1.
This change is safe.
Member
|
👍 |
Contributor
|
Good catch, thanks @HeahDude. |
Tobion
added a commit
that referenced
this pull request
Mar 25, 2016
This PR was merged into the 3.0 branch. Discussion ---------- [Form] Remove unused legacy code in `ChoiceType` | Q | A | ------------- | --- | Branch? | 3.0 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | - Commits ------- 8af78e9 [Form] Remove unused legacy code in `ChoiceType`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.