[Form] add test for ArrayChoiceList handling null #17832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| parent::setUp(); | ||
|
|
||
| $this->object = new \stdClass(); |
Contributor
Author
There was a problem hiding this comment.
this was broken because it was initialized after getChoices is called. so $this->object was actually null.
Contributor
There was a problem hiding this comment.
You should maybe just put it before the call to parent::setUp() instead of removing it and keep using $this->object in getChoices()
Member
|
Looks like this breaks the tests |
Member
|
Using |
Tobion
force-pushed
the
fix-array-choice-list-with-null
branch
from
ffac441 to
00e3819
Compare
Contributor
Author
|
Fixed |
Contributor
|
👍 Status: Reviewed |
Member
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Feb 18, 2016
This PR was merged into the 2.7 branch. Discussion ---------- [Form] add test for ArrayChoiceList handling null | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I found this bug but then realised that it was already fixed in #17511. So this just adds a test. Commits ------- 00e3819 [Form] add test for ArrayChoiceList handling null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this bug but then realised that it was already fixed in #17511.
So this just adds a test.