Skip to content

[Cache] Count cache hits/misses in ProxyAdapter #17734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabpot merged 1 commit into from
Mar 4, 2016
Merged

[Cache] Count cache hits/misses in ProxyAdapter #17734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions src/Symfony/Component/Cache/Adapter/ProxyAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ class ProxyAdapter implements CacheItemPoolInterface
{
private $pool;
private $createCacheItem;
private $hits = 0;
private $misses = 0;

public function __construct(CacheItemPoolInterface $pool)
{
Expand All @@ -47,8 +49,13 @@ public function getItem($key)
{
$f = $this->createCacheItem;
$item = $this->pool->getItem($key);
if ($isHit = $item->isHit()) {
++$this->hits;
} else {
++$this->misses;
}

return $f($key, $item->get(), $item->isHit());
return $f($key, $item->get(), $isHit);
}

/**
Expand Down Expand Up @@ -134,7 +141,33 @@ private function generateItems($items)
$f = $this->createCacheItem;

foreach ($items as $key => $item) {
yield $key => $f($key, $item->get(), $item->isHit());
if ($isHit = $item->isHit()) {
++$this->hits;
} else {
++$this->misses;
}

yield $key => $f($key, $item->get(), $isHit);
}
}

/**
* Returns the number of cache read hits.
*
* @return int
*/
public function getHits()
{
return $this->hits;
}

/**
* Returns the number of cache read misses.
*
* @return int
*/
public function getMisses()
{
return $this->misses;
}
}
17 changes: 17 additions & 0 deletions src/Symfony/Component/Cache/Tests/Adapter/ProxyAdapterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,21 @@ public function createCachePool()
{
return new ProxyAdapter(new ArrayAdapter());
}

public function testGetHitsMisses()
{
$pool = $this->createCachePool();

$this->assertSame(0, $pool->getHits());
$this->assertSame(0, $pool->getMisses());

$bar = $pool->getItem('bar');
$this->assertSame(0, $pool->getHits());
$this->assertSame(1, $pool->getMisses());

$pool->save($bar->set('baz'));
$bar = $pool->getItem('bar');
$this->assertSame(1, $pool->getHits());
$this->assertSame(1, $pool->getMisses());
}
}