[DEPRECATION] : deprecated support for Traversable in method ResizeFormListener::PreSubmit #17732
Conversation
ybensacq
commented
Feb 8, 2016
ybensacq
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #17701 |
| License | MIT |
| ----- | ||
|
|
||
| * deprecated the "choices_as_values" option of ChoiceType | ||
| * deprecated support for Traversable in `ResizeFormListener::PreSubmit` method |
There was a problem hiding this comment.
the method is called preSubmit without the uppercase.
ybensacq
force-pushed
the
ticket_17701
branch
from
9fffd39 to
188e780
Compare
| $form = $event->getForm(); | ||
| $data = $event->getData(); | ||
|
|
||
| if ($data instanceof \Traversable){ |
There was a problem hiding this comment.
Missing space before the curly brace and IMO this should be $data instanceof \Traversable && $data instanceof \ArrayAccess because if someone pass an object that implements Traversable but not ArrayAccess the deprecation will be thrown but the $data will be reseted to an empty array.
| $form = $event->getForm(); | ||
| $data = $event->getData(); | ||
|
|
||
| if ($data instanceof \Traversable) { |
There was a problem hiding this comment.
@HeahDude it's ok in my last commit :
ybensacq@554307c
There was a problem hiding this comment.
you updated only one of the two places in that commit
There was a problem hiding this comment.
Yes, tthe condition should be:
if ($data instanceof \Traversable && $data instanceof \ArrayAccess) {
@trigger_error('Support for Traversable is deprecated since version 3.1 and will be removed in 4.0. You should not use it anymore.', E_USER_DEPRECATED);
}
|
Thanks Yannick :) |
|
should also be documented in the upgrade files |
|
@HeahDude I think that do not worth it because at the moment of remove deprecated features I search for "trigger_error" or "E_USER_DEPRECATED" for example. |
|
Ok thanks, all is ok now. |
|
@dosten yes and then you have to search the code to remove or edit, so maybe a comment can be useful at this time. Besides that 👍 |
| $data = $event->getData(); | ||
|
|
||
| if ($data instanceof \Traversable && $data instanceof \ArrayAccess) { | ||
| @trigger_error('Support for objects implementing both \Traversable and \ArrayAccess is deprecated since version 3.1 and will be removed in 4.0.Use an array instead.', E_USER_DEPRECATED); |
There was a problem hiding this comment.
Missing space after the dot: will be removed in 4.0.Use an array
|
👍 Status: Reviewed |
|
Thank you @ybensacq. |
…method ResizeFormListener::PreSubmit (ybensacq) This PR was squashed before being merged into the 3.1-dev branch (closes #17732). Discussion ---------- [DEPRECATION] : deprecated support for Traversable in method ResizeFormListener::PreSubmit | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #17701 | License | MIT Commits ------- 68c9305 [DEPRECATION] : deprecated support for Traversable in method ResizeFormListener::PreSubmit
7 participants
