Skip to content

Conversation

@AlexandrePavy
Copy link

Fix Debug Toolbar on microsoft Edge

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass?
Fixed tickets
License MIT
Doc PR

I found one issue on Microsoft edge with debug toolbar

issue debug toolbar issue

i fixed the issue add width parameter on all SVG

fix microsoft edge

Reponsive design fixed

fix responsive design toolbar

Fix Debug Toolbar on microsoft Edge
@javiereguiluz
Copy link
Member

👍 I can't test it on Windows, but this is the same fix we recently applied in other PR. I've tested it in non-Windows systems and doesn't affect them in any way.

Status: reviewed

@AlexandrePavy AlexandrePavy changed the title Add width attribute on SVG [WebProfilerBundle] Add width attribute on SVG - Fix toolbar profiler on microsoft edge Feb 8, 2016
@fabpot
Copy link
Member

fabpot commented Feb 9, 2016

Thank you @AlexandrePavy.

fabpot added a commit that referenced this pull request Feb 9, 2016
…ar profiler on microsoft edge (AlexandrePavy)

This PR was submitted for the 3.0 branch but it was merged into the 2.8 branch instead (closes #17725).

Discussion
----------

[WebProfilerBundle] Add width attribute on SVG - Fix toolbar profiler on microsoft edge

Fix Debug Toolbar on microsoft Edge

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   |
| Fixed tickets |
| License       | MIT
| Doc PR        |

I found one issue on Microsoft edge with debug toolbar

<img width="1080" alt="issue debug toolbar issue" src="https://cloud.githubusercontent.com/assets/6603411/12887804/fdf4496a-ce76-11e5-8253-9be3861925ec.png">

i fixed the issue add width parameter on all SVG

<img width="1080" alt="fix microsoft edge" src="https://cloud.githubusercontent.com/assets/6603411/12887813/0a1e588e-ce77-11e5-825c-a9a0bb63b526.png">

Reponsive design fixed

<img width="537" alt="fix responsive design toolbar" src="https://cloud.githubusercontent.com/assets/6603411/12887825/180783c6-ce77-11e5-90c3-21e5d7759930.png">

Commits
-------

0ba88c2 Add width attribute on SVG
@fabpot fabpot closed this Feb 9, 2016
This was referenced Feb 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants